Is the supplication, "O Allah, take my soul while You are pleased with me," considered a form of wishing for death?

There is no harm in supplicating for Allah to take your soul while He is pleased with you. However, it is not permissible to wish for death due to worldly hardship or harm, as this is forbidden. It is permissible to supplicate for death only for a religious benefit, such as fearing temptation in one's religion or longing for Allah and His Messenger. It is disliked otherwise. One must maintain prayer and repent from any negligence therein. Despair of life stems from weakness of faith and the wiles of Satan. One should strive to strengthen faith and connect with Allah the Almighty, turning to Him in supplication, and not surrendering to despair.