What is the ruling on detesting the worldly life and wishing for death if it contains good?

It is not permissible for a Muslim to hate life and despair. Rather, he must show patience and seek reward from Allah when calamities befall him, and supplicate to Allah for relief. It is disliked to wish for death due to a harm that has befallen one, for the Prophet, peace and blessings be upon him, said: "None of you should wish for death due to a harm that has befallen him. If he must do so, then let him say: 'O Allah, keep me alive as long as life is better for me, and cause me to die if death is better for me.'" Calamities are an expiation for a Muslim if he seeks reward for them, and they awaken his heart from heedlessness.