Did God punish the Prophets, and was Joseph’s remaining in prison for several years a punishment from God for him because he asked his companion to mention him to his lord?

Firstly, the most evident interpretations regarding the story of Prophet Yusuf (peace be upon him) indicate that the one who forgot the mention of his Lord was not Yusuf (peace be upon him), but rather the other prisoner whom Yusuf asked to mention him to his master, the king. The verse aligns with his statement: "Mention me to your lord (rab)." The pronoun refers to the nearest antecedent, and Yusuf did not forget the remembrance of his Lord; rather, he was constantly remembering Him and inviting others to Him.

Secondly, Yusuf's (peace be upon him) statement to his companion in prison, "Mention me to your lord (rab)," does not refer to the Lordship of worship, but rather to the Lordship of kingship and administration. When "the Lord (al-Rabb)" is used without qualification, it refers solely to Allah Almighty. However, if it is qualified with something specific, such as the lord of the house or wealth, there is no harm in it. This might have been a way of addressing them in terms they understood, or it might have been permissible in their custom.