What is the ruling on benefiting from money earned by working in the military if it involves polytheistic elements?

The presence of Sharia-violating transgressions within the army does not render the salary received by its members unlawful, unless the work for which the salary is given is itself forbidden by Sharia. In that case, the salary would be in exchange for a prohibited benefit, thus making it unlawful.