Does the reward and recompense for making prayer rugs and prayer anoraks vanish if money is taken in exchange for them?

The person with a good intention will be rewarded for it, and Allah does not waste the reward of those who do good. The fact that the questioner receives payment for the items she provides to Muslims does not negate the reward for benefiting them and drawing them closer to their Lord, even if the reward of one who acts purely for Allah's sake is greater. So, let her intend to benefit Muslims and facilitate acts of worship for them.