Is worship for the sake of achieving a worldly matter that has not yet been realized considered a sound approach?

Whoever vows obedience to Allah, let him obey Him, whether his vow is absolute or conditional. If the vow is conditional upon a certain event, there is no harm in fulfilling it before that condition is met, but fulfilling it is not obligatory until the condition is met.