Does saving money in a piggy bank for a period of time by children constitute a violation of Sharia?

There is no harm in that, and it does not involve any religious transgression. The Prophet, peace and blessings be upon him, did it. If the intention is to train children in saving, economy, and avoiding extravagance, then it is good.