Which is better: absolute charity, or intercession through righteous deeds to relieve anxiety and achieve success, as in the story of the Companions of the Cave?

Giving charity with the intention of seeking Allah's reward and pleasure is better than giving charity to relieve distress or achieve success. Performing good deeds with the hope of reward does not negate sincerity, even if it falls short of the most perfect form. The story of the People of the Cave, upon whom a rock fell, indicates that they supplicated to Allah by virtue of their good deeds, which they had performed seeking His countenance, so that He might relieve their distress. They did not initially intend, through their righteous deeds, to seek the relief of distresses.