Is my understanding that affliction is reprehensible in religion correct, despite its contradiction with the saying of some scholars? And can the reward be in abundance of good deeds instead of tribulation?

The meaning of affliction (ibtila') in the aforementioned statement can be interpreted as the hardships that befall a person due to bearing the burdens of Sharia and the concerns of religion, which is better than being afflicted by worldly matters. As for the prophetic supplication, "And do not make our calamity (musibah) in our religion," the calamity here refers to a misfortune that weakens religion, and there is a great difference between a calamity in religion and a calamity in worldly affairs.

And uttering a supplication against affliction altogether contradicts the Sunnah (way) of Allah the Almighty, for He says: (And We will surely test you with something of fear and hunger...) and His saying: (You will surely be tested in your possessions and yourselves), and His saying: (And We test you with evil and with good). The pious predecessors disliked supplication against affliction absolutely.

The prohibited supplication is any request that contradicts Allah's wisdom or His law, or that implies something contrary to what He has informed. Some scholars have forbidden asking for ordinary impossibilities, or asking to be free from pains and illnesses forever.

It is better for a Muslim to seek the supplications from the Quran and Sunnah, such as asking for 'aafiyah (well-being), which is safety in religion, body, family, and wealth, like: "O Allah, I ask You for 'aafiyah in this world and the Hereafter," and "O Allah, I seek refuge in You from the cessation of Your blessing, the turning away of Your 'aafiyah, the suddenness of Your vengeance, and all Your displeasure."