Does the continued estrangement between a person and his children, after his repentance and diligent seeking of forgiveness for the major sins he committed that led to his punishment with affliction, illness, and estrangement, mean that his repentance is not sound?

The servant is required to fulfill the conditions of repentance while thinking good of Allah that He will accept it. However, the acceptance or rejection of repentance is a matter of the unseen, of which the servant has no knowledge. It cannot be definitively stated that the removal of affliction is a sign of acceptance, or that its persistence is a sign of rejection. Affliction is not always a punishment; rather, it may be for elevating one's ranks or as a test and purification. The sinner must engage in sincere repentance and rejoice in Allah's acceptance of his repentance.