Is there any basis for the story of the man who saved money for Hajj, then gave it away as charity, and was subsequently seen performing Hajj?

The virtues of deeds are known to Allah through legal evidence, such as texts or consensus, not through dreams. "Recommendation is a legal ruling and is only established by legal evidence." When there is a conflict between Hajj and charity, what is more beloved to Allah is prioritized based on legal evidence. Hajj takes precedence over voluntary charity, whether it is obligatory or supererogatory. Obligatory Hajj is a pillar of Islam, and it is the most beloved deed by which a servant draws near to Allah. Voluntary Hajj is better than voluntary charity, except in exceptional cases such as "charity to relatives," or in "Jihad in the cause of Allah," or "to people in dire need," or for the construction of a mosque. If both are voluntary, Hajj is better because it is a physical and financial act of worship, provided that one fulfills obligations and avoids prohibitions. For one who intended to perform voluntary Hajj but then diverted to a more beneficial charity, there is hope for reward for their intention.