Does the disagreement regarding the validity of repentance while persisting in another sin apply to a disbeliever or an apostate if they embrace Islam while persisting in a disobedience, or is their conversion to Islam valid in all cases?

If a person repents of a sin while persisting in another, the sin they repented of is forgiven.

As for a disbeliever or an apostate who embraces Islam while persisting in a sin they have not repented of, their Islam is valid by consensus. However, is the sin they did not repent of forgiven through this Islam? There are two opinions on this matter:

The first: All of their sins are forgiven due to the generality of the Prophet's (peace be upon him) saying: "Islam demolishes what was before it."

The second (which is the sounder view): That only the sins they repented of are forgiven. So, if they embrace Islam while persisting in major sins short of disbelief, their ruling is like that of Muslim perpetrators of major sins. This is what the fundamental principles and texts indicate, such as the Prophet's (peace be upon him) saying to Hakim ibn Hizam: "Whoever amongst you performs well in Islam will not be held accountable for what they did in the time of ignorance. And whoever performs badly in Islam will be held accountable for the first and the last."

"Good performance in Islam" (حسن الإسلام) means that a Muslim adheres to doing what Allah has commanded and abandoning what He has forbidden. This is the meaning of general repentance. So, whoever embraces Islam in this manner, all their sins are forgiven.