Is a person considered a miser if he saves money for his children's future amidst difficult economic circumstances, and refuses to give them the full amount for their marriage unless they contribute, while the children believe he should provide everything for them?

You are not a miser if you fulfill your obligatory financial duties such as zakat and expenditures; for blameworthy miserliness (bukhl) in Islamic law is the refusal to perform what Allah has enjoined. The Sharia has encouraged moderation in spending, with neither extravagance nor stinginess, and the best of matters are their middles. Whoever spends economically, neither extravagantly nor sparingly, will not become poor. It is commendable to encourage children to earn a lawful living, but a wealthy father must marry off a needy son, while preparing daughters for marriage is the duty of the husband. Allah has promised recompense and a great reward for whoever spends on his family, and this reward is greater than spending in the way of Allah or on the poor.