Will the pilgrim who intended to perform Hajj and applied for the Hajj lottery every year, but was not successful, be rewarded?

If you exert your effort to perform Hajj, and Allah knows the sincerity of your intention, and nothing prevents you except inability, then the reward for what you intended will be written for you. Sheikh al-Islam Ibn Taymiyyah says that whoever firmly resolves to do something and does what he is able to do, is considered as one who has done it.